Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Elm] Fix elm code generation for array type request param #7890

Closed
wants to merge 5 commits into from
Closed

[WIP] [Elm] Fix elm code generation for array type request param #7890

wants to merge 5 commits into from

Conversation

sayanarijit
Copy link

Enclose array values inside ().

e.g.

From:

getArticles : Maybe List ArticleCategory -> Api.Request ()

To:

getArticles : Maybe (List ArticleCategory) -> Api.Request ()

Fixes: #7889

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@sayanarijit
Copy link
Author

cc @eriktim

@sayanarijit sayanarijit changed the title Fix elm code generation for array type request param [Elm] Fix elm code generation for array type request param Nov 6, 2020
@sayanarijit
Copy link
Author

Ok It generates Maybe (List ArticleCategory) -> Api.Request () but we actually need Maybe (List Api.Data.ArticleCategory) -> Api.Request (). i.e. isModel for the item should be true.

@sayanarijit sayanarijit changed the title [Elm] Fix elm code generation for array type request param [WIP] [Elm] Fix elm code generation for array type request param Nov 6, 2020
sayanarijit and others added 4 commits November 22, 2020 15:13
Enclose array values inside `()`.

e.g.

From:

```elm
getArticles : Maybe List ArticleCategory -> Api.Request ()
```

To:

```elm
getArticles : Maybe (List ArticleCategory) -> Api.Request ()
```

Fixes: #7889
@sayanarijit sayanarijit changed the title [WIP] [Elm] Fix elm code generation for array type request param [Elm] Fix elm code generation for array type request param Nov 22, 2020
@sayanarijit sayanarijit changed the title [Elm] Fix elm code generation for array type request param [WIP] [Elm] Fix elm code generation for array type request param Nov 22, 2020
@sayanarijit
Copy link
Author

Not yet fixed.

It generates:

module Api.Request.Default exposing
    ( getArticles
    )

import Api
import Api.Data
import Dict
import Http
import Json.Decode
import Json.Encode


getArticles : Maybe (List Api.Data.ArticleCategory) -> Api.Request ()
getArticles category_query =
    Api.request
        "GET"
        "/articles"
        []
        [ ( "category", Maybe.map (String.join "," << List.map stringFrom) category_query ) ]
        []
        Nothing
        (Json.Decode.succeed ())

@Erudition
Copy link

That looks fixed to me!

@sayanarijit
Copy link
Author

I think there are still some edge cases. However, I think those are easily avoidable. Due to poor time management skills, I'm not able to continue working on this PR, hence closing this. Feel free to take over though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][Elm] Invalid syntax for array type query params
3 participants