Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nim] bugfix for the case when path contains multiple parameters #8402

Merged

Conversation

darklynx
Copy link
Contributor

If REST end-point has a path with multiple parameters current api.mustache generates a broken Nim-code by repeating path string multiple times, for example:

proc getCompanyUser*(httpClient: HttpClient, companyId: string, userId: string): (Option[User], Response) =
  ## Get user of a company

  let response = httpClient.get(basepath & fmt"/companies/{companyId}/users/{userId}"fmt"/companies/{companyId}/users/{userId}")
  constructResult[User](response)

after this fix is applied the result will be as is was designed by original author:

proc getCompanyUser*(httpClient: HttpClient, companyId: string, userId: string): (Option[User], Response) =
  ## Get user of a company

  let response = httpClient.get(basepath & fmt"/companies/{companyId}/users/{userId}")
  constructResult[User](response)

Note: unfortunately Petstore example does not contain any API paths with 2 or more path parameters, otherwise the issue could have been caught before.

Note 2: unfortunately Nim language has no members in Technical Committee

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run
    mvn clean package
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    to update all Petstore samples related to your fix.
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

…epetiotion if path contains multiple parameters
@wing328
Copy link
Member

wing328 commented Jan 11, 2021

cc @hokamoto (creator of the Nim client generator)

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with multiple path parameters and the result seems good (no compilation issue)

@wing328 wing328 merged commit 6e4c130 into OpenAPITools:master Jan 19, 2021
@wing328 wing328 changed the title Nim client template bugfix for the case when path contains multiple parameters [Nim] bugfix for the case when path contains multiple parameters Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants