Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] the replace statement in parseDate is too greedy (#8632) #8633

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

tray2100
Copy link
Contributor

@tray2100 tray2100 commented Feb 7, 2021

Fix for #8632

  • updated the regex used in the String.replace for parseDate() to more precisely target ISO-8601
  • added the replace function call to the ES6 mustache file

PR checklist

  • [x ] Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jfiala @wing328

)

* updated the regex used in the String.replace for parseDate() to more precisely target ISO-8601
* added the replace function call to the ES6 mustache file
@wing328 wing328 merged commit 75b9871 into OpenAPITools:master Feb 8, 2021
@wing328
Copy link
Member

wing328 commented Mar 22, 2021

@tray2100 thanks for the PR, which has been included in the v5.1.0 release: https://twitter.com/oas_generator/status/1373636654024380423

@PetrPy
Copy link

PetrPy commented Jun 1, 2021

The parseDate function does not work in Safari, tested on version 14.1.1 (16611.2.7.1.4).

The following:

new Date("2021-05-28 18:57:50.843933")

works well in Chrome, but Safari requires the "T" letter to be included as a separator of date and time parts. However, the following would work in both browsers:

new Date("2021-05-28T18:57:50.843933")    // note the T letter

I suggest that the command:

return new Date(str.replace(/(\d)(T)(\d)/i, '$1 $3'));

is simply replaced with:

return new Date(str);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants