Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Fix syntax error #8675

Merged
merged 1 commit into from
Feb 11, 2021
Merged

[ruby] Fix syntax error #8675

merged 1 commit into from
Feb 11, 2021

Conversation

miyucy
Copy link
Contributor

@miyucy miyucy commented Feb 11, 2021

Added missing closing brace in list_invalid_properties model method.

PR checklist

  • Read the contribution guidelines.

  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.

  • Run the following to build the project and update samples:

    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    

    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.

  • File the PR against the correct branch: master, 5.1.x, 6.0.x

  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

    @cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)

Added missing closing brace in list_invalid_properties model method.
@auto-labeler
Copy link

auto-labeler bot commented Feb 11, 2021

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328 wing328 added this to the 5.1.0 milestone Feb 11, 2021
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, which looks good to me

@wing328 wing328 merged commit 3c4b1a0 into OpenAPITools:master Feb 11, 2021
@miyucy miyucy deleted the fixbrace branch February 11, 2021 15:55
@wing328
Copy link
Member

wing328 commented Mar 22, 2021

@miyucy thanks for the PR, which has been included in the v5.1.0 release: https://twitter.com/oas_generator/status/1373636654024380423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants