Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] bug fix (breaking), minor code format enhancement #8715

Merged
merged 3 commits into from
Feb 20, 2021

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Feb 16, 2021

  • bug fix for required parameters in the parent class. Example (breaking as this bug fix changes the method signature)
  • minor code format enhancement

cc @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 changed the title [Go] minor code format enhancement [Go] bug fixes (breaking) minor code format enhancement Feb 16, 2021
@wing328 wing328 changed the title [Go] bug fixes (breaking) minor code format enhancement [Go] bug fixes (breaking), minor code format enhancement Feb 16, 2021
@wing328 wing328 added this to the 5.1.0 milestone Feb 16, 2021
@wing328 wing328 marked this pull request as ready for review February 16, 2021 06:44
@wing328 wing328 changed the title [Go] bug fixes (breaking), minor code format enhancement [Go] bug fix (breaking), minor code format enhancement Feb 17, 2021
@wing328 wing328 merged commit ba4aae5 into master Feb 20, 2021
@wing328 wing328 deleted the go_format_enhance branch February 20, 2021 03:50
@therve
Copy link
Contributor

therve commented Feb 24, 2021

Hi, this breaks our generation in a few small cases due to the change in model_simple. It looks like requiredVars and allVars don't handle nullables correctly, we end up with invalid types like Newbool and Newint64 instead of NewNullableBool and NewNullableInt64. Wondering if you have an idea.

Edit: #8820 I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants