Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-axios] Support array query arguments #8772

Merged
merged 2 commits into from
Feb 21, 2021

Conversation

dantman
Copy link
Contributor

@dantman dantman commented Feb 19, 2021

typescript-axios does not correctly output query arguments when you use explode: true for a parameter.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

fixes #7966
fixes #7973

typescript-axios does not correctly output query arguments when you use `explode: true` for a parameter.

fixes OpenAPITools#7966
fixes OpenAPITools#7973
@auto-labeler
Copy link

auto-labeler bot commented Feb 19, 2021

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@TiFu TiFu merged commit 047a71c into OpenAPITools:master Feb 21, 2021
@TiFu
Copy link
Contributor

TiFu commented Feb 21, 2021

Merged - Thank you for your pull request (and patience ;))!

@wing328 wing328 added this to the 5.1.0 milestone Mar 16, 2021
@wing328
Copy link
Member

wing328 commented Mar 22, 2021

@dantman thanks for the PR, which has been included in the v5.1.0 release: https://twitter.com/oas_generator/status/1373636654024380423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants