Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JS client case sensitive wrt. reserved words #8905

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

delenius
Copy link
Contributor

@delenius delenius commented Mar 5, 2021

Fixes #8904

Changes to JavascriptClientCodegen.java to make it case insensitive for reserved word detection.
Note: I left the main DefaultCodegen.java alone, because it affects all the generators. My changes are local to the JS client generator.

Pinging JS tech committee: @CodeNinjai @frol @cliffano

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CircleCI failure seems not related to this change.

@wing328 wing328 merged commit 7b5a583 into OpenAPITools:master Mar 6, 2021
@wing328 wing328 added this to the 5.1.0 milestone Mar 6, 2021
@wing328
Copy link
Member

wing328 commented Mar 6, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][JavaScript] client generator: Reserved words detector is not case-sensitive
2 participants