Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds getAdditionalPropertiesIsAnyType to java schema classes #8908

Merged

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Mar 6, 2021

Adds getAdditionalPropertiesIsAnyType/setAdditionalPropertiesIsAnyType to java schema classes
This is needed if one is generating classes for object schemas.
By default object schema includes additionalProperties = AnyType, so if this boolean is False, then one needs to generate a custom class for the object schema.
Tests added of X.getAdditionalPropertiesIsAnyType for:

  • CodegenModel
  • CodegenProperty
  • CodegenParameter
  • CodegenResponse

This will be used in:
#8325
And will probably want to be used in go-experimental @wing328
We may want to replace isAdditionalPropertiesTrue with getAdditionalPropertiesIsAnyType @wing328
getAdditionalPropertiesIsAnyType applies to all schema models and is also set to true if the user manually defined an additionalProperties in their spec and its value is any type schema.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether spacether changed the title Adds additional properties is any type Adds getAdditionalPropertiesIsAnyType to java schema classes Mar 6, 2021
@spacether spacether added this to the 5.1.0 milestone Mar 6, 2021
@spacether spacether marked this pull request as draft March 6, 2021 09:06
@spacether spacether closed this Mar 7, 2021
@spacether spacether reopened this Mar 7, 2021
@spacether spacether marked this pull request as ready for review March 7, 2021 06:06
@spacether spacether closed this Mar 7, 2021
@spacether spacether reopened this Mar 7, 2021
@spacether
Copy link
Contributor Author

The travis-ci error is unrelated to this change so I am merging this.

@spacether spacether merged commit 101da6e into OpenAPITools:master Mar 7, 2021
@spacether spacether deleted the adds_additionalPropertiesIsAnyType branch March 7, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant