Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript-angular: Fix Cannot read property 'apiKey' of undefined #9260

Merged
merged 2 commits into from
Apr 16, 2021

Conversation

EmmanuelRoux
Copy link
Contributor

@EmmanuelRoux EmmanuelRoux commented Apr 14, 2021

This fixes #9259 and may possibly fix #8980 and fix #8983

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@EmmanuelRoux EmmanuelRoux changed the title Fix #9259 Fix Cannot read property 'apiKey' of undefined #9259 Apr 14, 2021
@EmmanuelRoux
Copy link
Contributor Author

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny macjohnny added this to the 5.1.1 milestone Apr 16, 2021
@macjohnny macjohnny changed the title Fix Cannot read property 'apiKey' of undefined #9259 typescript-angular: Fix Cannot read property 'apiKey' of undefined Apr 16, 2021
@macjohnny macjohnny merged commit 0329119 into OpenAPITools:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment