Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bash] Fix matching of header parameters #9370

Merged
merged 1 commit into from
May 10, 2021

Conversation

devnev
Copy link
Contributor

@devnev devnev commented Apr 29, 2021

Currently a generated bash client will not append headers as documented:

bash samples/client/petstore/bash/petstore-cli --dry-run --host localhost getPetById a:b
curl  -sS --tlsv1.2   -X GET "localhost/v2/pet/"

This PR fixes the generated client to match Header-Name: Header-Value parameters and add them to the request:

bash samples/client/petstore/bash/petstore-cli --dry-run --host localhost getPetById a:b
curl  -sS --tlsv1.2 -H "a: b"   -X GET "localhost/v2/pet/"

@frol @bkryza @kenjones-cisco

@wing328
Copy link
Member

wing328 commented May 10, 2021

LGTM but I've not tested it locally.

@wing328 wing328 merged commit ae2423e into OpenAPITools:master May 10, 2021
@devnev devnev deleted the bash-fix-header-params branch January 20, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants