Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crystal][client] some fix and minor improvement #9416

Merged
merged 5 commits into from
May 10, 2021

Conversation

YusukeHosonuma
Copy link
Contributor

This PR fix follows.

  • Remove redundant include JSON::Serializable.
  • Fix syntax-error in Hash literal.
  • Fix shardName in shard.yml.
  • Add explicitly require "json"

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328

@wing328
Copy link
Member

wing328 commented May 10, 2021

@YusukeHosonuma thanks for the PR, which looks good to me.

@wing328 wing328 merged commit 1751aa7 into OpenAPITools:master May 10, 2021
@YusukeHosonuma
Copy link
Contributor Author

@wing328
Thanks for review!
If I find some improvement, I'll another PR.

@YusukeHosonuma YusukeHosonuma deleted the patch/crystal branch May 10, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants