Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++ Qt5 server] Improvements for Qt5 server #942

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

etherealjoy
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • Remove beta tag
  • Support nested containers
  • Move repetitive code to inline function
  • Fix docker file to use correct binary name
  • Fix CMakeLists.txt when building external dependencies

@stkrwork @wing328 @MartinDelille @fvarose @ravinikam

Remove beta tag
Supported nested containers
Move repetitive code to inline function
Fix docker file
Fix CMakeLists.txt when building external project
@etherealjoy etherealjoy added this to the 3.3.0 milestone Sep 12, 2018
@etherealjoy etherealjoy merged commit 3cfcf77 into OpenAPITools:master Sep 12, 2018
@etherealjoy etherealjoy deleted the qt5-server-fixes branch September 12, 2018 07:52
jaumard pushed a commit to jaumard/openapi-generator that referenced this pull request Sep 21, 2018
Remove beta tag
Supported nested containers
Move repetitive code to inline function
Fix docker file
Fix CMakeLists.txt when building external project
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Remove beta tag
Supported nested containers
Move repetitive code to inline function
Fix docker file
Fix CMakeLists.txt when building external project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants