Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [typescript] Duplicate parameter's names (rename options to _options and config to _config) #9428

Merged
merged 2 commits into from
May 10, 2021
Merged

[BUG] [typescript] Duplicate parameter's names (rename options to _options and config to _config) #9428

merged 2 commits into from
May 10, 2021

Conversation

ksvirkou-hubspot
Copy link
Contributor

@ksvirkou-hubspot ksvirkou-hubspot commented May 7, 2021

fixes #9425

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ksvirkou-hubspot
Copy link
Contributor Author

@macjohnny macjohnny added this to the 5.2.0 milestone May 10, 2021
Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny macjohnny merged commit 686b211 into OpenAPITools:master May 10, 2021
@ksvirkou-hubspot ksvirkou-hubspot deleted the bug/typescriptFixParamNameing branch May 12, 2021 09:22
@matrix4123
Copy link

This bug seems to still exist in the typescript-axios generator. I am guessing we need to make similar changes across all of the typescript-* generators?

@ksvirkou-hubspot
Copy link
Contributor Author

This bug seems to still exist in the typescript-axios generator. I am guessing we need to make similar changes across all of the typescript-* generators?

This bug was fixed only for typescript generator but it wasn't fixed for typescript-axios generator.

@matrix4123
Copy link

This bug seems to still exist in the typescript-axios generator. I am guessing we need to make similar changes across all of the typescript-* generators?

This bug was fixed only for typescript generator but it wasn't fixed for typescript-axios generator.

Thanks for reply, I'll see if I can make a fix! 👍🏼

@teddybee
Copy link

teddybee commented Mar 24, 2022

I have jut run into the issue with typescript-axios generator. There is a generated function param name: "options" and the AxiosRequestConfig param is also "options" so the typescript compiler is freaking out.
I renamed the second options param by hand to axiosOptions in 400 rows...

P.S: sometimes I found options?: any instead of options?: AxiosRequestConfig in the generated code, I think its another bug/issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [typescript] Duplicate parameter's names (options and config)
4 participants