[BUG][dart-dio-next] Fixes content-type prioritization #9454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continue looping consumes while any known media type is found
|
Did you regenerate the samples? If so, this would mean we don't have this case in the samples or we use it differently in the templates. |
themisir
changed the title
themisir
changed the title
Generator now picks first matching supported ("application/json", "application/x-www-form-urlencoded", "multipart/form-data") content type, if none available, it uses first mediaType or default value which is 'application/json'
I just did, but maybe the samples might not contain my case. UPDATE: I've checked with our private openapi schema which had the issue mentioned in #9334 and it worked. |
themisir
changed the title
|
@kuhnroyal can you please review the changes? |
|
This looks pretty good, I have just fixed some CI problems on master, can you please rebase and see if it goes green. |
5 tasks
I rebased, but checks still fails. |
|
I think this can be closed and is superseded by #9517 |
Sure. |
|
Thank you for your input on this! |
themisir
changed the title
kuhnroyal
added a commit
to kuhnroyal/openapi-generator
that referenced
this pull request
May 21, 2021
* fixes OpenAPITools#9334 * superseeds OpenAPITools#9454 * use `prioritizedContentTypes` in the same way `JavaClientCodegen` does * move `application/json` to the front if it exists * don't do anything if it is multi-part or url-encoded as for this the first content-type already needs to match * log warning if an unsupported content-type is first after prioritizing * remove some unused code blocks from dio generators
wing328
pushed a commit
that referenced
this pull request
May 24, 2021
* [dart] Improve content-type handling * fixes #9334 * superseeds #9454 * use `prioritizedContentTypes` in the same way `JavaClientCodegen` does * move `application/json` to the front if it exists * don't do anything if it is multi-part or url-encoded as for this the first content-type already needs to match * log warning if an unsupported content-type is first after prioritizing * remove some unused code blocks from dio generators * Only use first prioritized content-type in dio generators * don't default to any content-type in dio-next, dio defaults itself to JSON
premiumitsolution
pushed a commit
to premiumitsolution/openapi-generator
that referenced
this pull request
May 26, 2021
* [dart] Improve content-type handling * fixes OpenAPITools#9334 * superseeds OpenAPITools#9454 * use `prioritizedContentTypes` in the same way `JavaClientCodegen` does * move `application/json` to the front if it exists * don't do anything if it is multi-part or url-encoded as for this the first content-type already needs to match * log warning if an unsupported content-type is first after prioritizing * remove some unused code blocks from dio generators * Only use first prioritized content-type in dio generators * don't default to any content-type in dio-next, dio defaults itself to JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that generator first looks if consumer contains any of the supported media types ("application/json", "application/x-www-form-urlencoded", "multipart/form-data").
If it does generator sets first one to 'x-content-type' parameter. Otherwise 'x-content-type' parameter value will be either the first consumer's media type (same behavior as previously generator but the whole thing is happening on generator side instead of doing
[ ... ].first) or default value which is "application/json" (also same as old behavior).Fixes #9334. Please check the issue for more details.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.x