Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Boolean in R client generator #9469

Merged
merged 2 commits into from
May 15, 2021

Conversation

sneumann
Copy link
Contributor

@sneumann sneumann commented May 12, 2021

Hi @Ramanth @saigiridhar21 et al,

as mentioned in the branch name, this PR is in response to (my) #9468 . Unfortunately I am not a openapi-generator hacker, so I have no idea if this is what's required, and its a best-effort approach. What I did:

  1. extend the model.mustache in two places to check for the correct class, and I did that in analogy to the lines before/after my insertion
  2. extend the model.mustache in two places further down, where numbers are printed with %d% and everything else was printed as "%s". The latter needed changing. I HOPE what I did results in unchanged "%s" for everything but Boolean, and %s for booleans
  3. finally the logical values are needed in lowercase, so I surrounded self${{baseName}}bytolower()` in case of booleans.

The second commit adds the petstore, changed only where the logical complete is involved.
And apparently my editor removed an empty line at the end of the template, so some changes remove only whitespace
I do not know exactly how else I can test everything. Hope that helped nevertheless,
Yours,
Steffen

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented May 15, 2021

@sneumann thanks for the PR. Tested locally and the result is good 👍

@wing328 wing328 merged commit 97ddcc2 into OpenAPITools:master May 15, 2021
premiumitsolution pushed a commit to premiumitsolution/openapi-generator that referenced this pull request May 26, 2021
* Add support for Boolean in R client generator

* Regenerated with updated R generator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants