Adds isShort + isUnboundedInteger to IJsonSchemaValidationProperties implementers #9519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
reviewed
May 20, 2021
modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenModel.java
Outdated
Show resolved
Hide resolved
spacether
changed the title
|
Updating isInteger to mean unbounded integers and isShort to mean int32 resulted in the following 123 files changing: Fixing them is too much work for me to do in this PR.
|
spacether
changed the title
|
closing and re-opening to try to kick off bitrise |
|
CircleCi error is unrelated |
|
closing and re-opening to try to travis to run. |
|
Errors are unrelated to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds isShort + isUnboundedInteger to IJsonSchemaValidationProperties implementers
This allows CodegenModel CodegenResponse CodegenParameter CodegenResponse
to be able to tell the difference in the templates between an int32 parameter and an unbounded integer parameter
When merged, this will resolve
#9447 (comment)
This is not a breaking change with fallback because isInteger behaves the same.
If one needs to differentiate between int32 and unbounded integers, one should use the template variables:
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.x