Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dart 2] Fix petstore tests #954

Merged
merged 2 commits into from Sep 2, 2018
Merged

[Dart 2] Fix petstore tests #954

merged 2 commits into from Sep 2, 2018

Conversation

ghost
Copy link

@ghost ghost commented Sep 2, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fix #754 (comment)
cc @wing328

@ghost ghost changed the title [Dart 2]Fix petstore tests [Dart 2] Fix petstore tests Sep 2, 2018
@wing328
Copy link
Member

wing328 commented Sep 2, 2018

@swipesight thanks for the quick fix, which looks good to me.

cc @ircecho (2017/07)

@wing328 wing328 added this to the 3.3.0 milestone Sep 2, 2018
@wing328 wing328 merged commit 8ccb713 into OpenAPITools:master Sep 2, 2018
@ghost ghost deleted the update-petstore-tests branch September 2, 2018 07:49
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* properly initialized models in tests

* Revert "move dart2 test to the end"

This reverts commit 7d2edf4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant