Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Java][Spring] Fix for #8659 - Different in-parameter types - fix for #9462 #9555

Merged
merged 1 commit into from
May 23, 2021

Conversation

agilob
Copy link
Contributor

@agilob agilob commented May 22, 2021

This reverts commit b9a1c8f.

Reverts of PR #9331 to fix #9462

However, the newly generated interface contract cannot be satisfied in a clean way, as MultipartFile is not supposed to be a return value. See Spring documentation of MultipartFile

A representation of an uploaded file received in a multipart request.

The file contents are either stored in memory or temporarily on disk. In either case, the user is responsible for copying file contents to a session-level or persistent store as and if desired. The temporary storage will be cleared at the end of request processing.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@beckerjohannes @wing328 @EmhyrVarEmreis

…eter types generated for api and delegate for files (OpenAPITools#9331)"

This reverts commit b9a1c8f.
@wing328
Copy link
Member

wing328 commented May 23, 2021

@agilob thanks for the PR to revert the change.

@wing328 wing328 added this to the 5.2.0 milestone May 23, 2021
@wing328 wing328 merged commit b1cba96 into OpenAPITools:master May 23, 2021
premiumitsolution pushed a commit to premiumitsolution/openapi-generator that referenced this pull request May 26, 2021
…eter types generated for api and delegate for files (OpenAPITools#9331)" (OpenAPITools#9555)

This reverts commit b9a1c8f.
@agilob agilob deleted the revert-9331 branch September 25, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants