Define content type only if the body is not empty #9766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the samples via item3 in the PR checklist: https://github.com/OpenAPITools/openapi-generator/blob/master/.github/PULL_REQUEST_TEMPLATE.md so that the CI can test the change. |
How do I make the results of the Git Bash visible to you? Are there files to change/commit to? |
|
Yes please commit the changes in the sample as well. |
|
I have updated the samples folder. |
|
cc @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @arun-nalla (2019/11) @spacether (2019/11) |
romanblack1
force-pushed
the
romanblack1-patch-1-1
branch
from
8410564
to
5203b0e
Compare
wing328
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content type is now only defined if the body is not empty. It used to define empty bodies and the default "application/json." This satisfies the request #8116. This change aims to change the python client only.
I ran the desired commands on Git Bash without errors, but I am still new to this so I might have missed a step somewhere, let me know if there is anything I missed.