Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elixir] Adding :package and :description to mix.exs template #9945

Merged
merged 2 commits into from Jul 16, 2021

Conversation

tobbbles
Copy link
Contributor

@tobbbles tobbbles commented Jul 14, 2021

Closes #9944

Adds additional values to mix.exs to enable publishing generated packges to Hex.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@tobbbles
Copy link
Contributor Author

cc @mrmstn

@mrmstn
Copy link
Contributor

mrmstn commented Jul 15, 2021

Hi @tobbbles, thank you very much for your PR!
Great to see that some generated clients will find their way to hex.pm.
Sadly I've no experience in publishing packages, but your changes look good to me so lets give it a shot 😁!

@wing328 wing328 added this to the 5.2.1 milestone Jul 16, 2021
@wing328 wing328 merged commit 8df43a1 into OpenAPITools:master Jul 16, 2021
@tobbbles tobbbles deleted the feature/elixir-mix-package branch July 16, 2021 09:03
[
name: "{{#underscored}}{{packageName}}{{/underscored}}",
files: ~w(lib mix.exs README* LICENSE*),
licenses: ["{{licenseId}}"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobbbles I couldn't find a way to set licenseId - do you know how we can set that value?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was easy enough ... ory/sdk@20f602a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] Elixir Package configuration
4 participants