Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump openapi-generator and sbt version #45

Conversation

polentino
Copy link
Contributor

This PR aims to update openapi-generator to a more recent version, reason being: when compiling the generated code, this error appears

[error] [E1] openapi/src/main/scala/org/openapitools/client/core/JsonSupport.scala
[error]      object client is not a member of package sttp
[error]      did you mean client3?
[error]      L16: import sttp.client.json4s.SttpJson4sApi

this is due to the fact that the artifact was moved:

Note: This artifact was moved to:

com.softwaremill.sttp.client3 » core

I also bumped sbt version in order to be able to run it on macos, but that's not a hard requirement.

@wing328
Copy link
Member

wing328 commented Sep 22, 2022

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@polentino polentino force-pushed the fix/master/bump-openapi-generator-version branch from 818b3dc to 53fbdf7 Compare September 22, 2022 12:19
@polentino
Copy link
Contributor Author

Thanks, didn't notice that! I've update the commit and now should be fine.

@polentino
Copy link
Contributor Author

bump 🙏

@wing328
Copy link
Member

wing328 commented Oct 4, 2022

Looks good to me. If no further feedback, I'll merge it in the coming weekend.

@wing328
Copy link
Member

wing328 commented Oct 4, 2022

cc @jrouly

@wing328 wing328 merged commit 36cc8b7 into OpenAPITools:master Oct 17, 2022
@wing328
Copy link
Member

wing328 commented Oct 17, 2022

FYI. I've updated the openapi generator version to the latest via 38c6944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants