Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors and Docker pipelines #25

Closed
wants to merge 9 commits into from
Closed

Conversation

MrStanana
Copy link

@MrStanana MrStanana commented Mar 19, 2024

Unfortunately, since I have just started working on this project, some of the work in this PR may not align with the current direction of the project. Nonetheless, I believe some of this work may still be useful for the project, and I will refer to the Trello board to check what needs to be done.

Since different people have different systems, including low resource systems, some things might need to be further simplified, such as unifying the servers into one single piece of software.

Finally, I understand this is too large of a PR, but I thought i shouldn't clutter the PR list. We'll later discuss how to split this into smaller PRs. Please let me know if there are any contributing guidelines to follow.

Please take a look and let me know what you think.

The objectives of my work were:

  • Unify all servers into a single language, preferably a strongly typed, compiled language
  • Minimize external dependencies, both libraries and external software
  • Containerize the server, for easy deployment and scaling
  • Load configuration from env vars
  • Improve documentation and comments
  • Add style guides and automatic formatting
  • [API] Move authentication and database layers into injected dependencies, allowing multiple implementations
  • Add sanity check tests
  • Add automatic TLS certificate generation

TODO:

  • Continue unifying servers into a single language; maybe a single piece of software
  • Add more tests
  • Add admin endpoints to API
  • Replace game server database access with HTTP admin requests
  • Dynamic env vars with defaults in proxy server caddy.json. See Support default values in placeholders caddyserver/caddy#5275

@CakeLancelot
Copy link
Member

Sorry, but at this time we will not be able to accept this pull request. The project is in an early state at the moment and things being in flux the way that they are, adding containerization and new languages to the mix will cause unnecessary developer friction. In addition, if something like Docker were to be added I would prefer to still have the non-Docker instructions available.

I do not mind if smaller PRs are opened to fix issues, however we will not be changing the tech stack too much at this time.

Thank you for your understanding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants