Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate incoming recipes #39

Closed
jakerye opened this issue Jun 7, 2018 · 3 comments
Closed

Validate incoming recipes #39

jakerye opened this issue Jun 7, 2018 · 3 comments
Assignees
@rbaynes
Labels
enhancement New feature or request urgent Mission critical fix immediately
Milestone
v1.0.1 feature fr...

Comments

@jakerye
Copy link
Contributor

jakerye commented Jun 7, 2018 •
edited by rbaynes
Loading

  • Don't let unvalidated recipes make it into the database.
  • Compare recipe version to about.json recipe_version. Ignore if they don't match and log an error.
@rbaynes rbaynes added this to the v0.1.1 release sprint milestone Jun 25, 2018
@rbaynes rbaynes self-assigned this Aug 1, 2018
@rbaynes
Copy link
Contributor

rbaynes commented Aug 20, 2018

what did we decide to do with "versioning" a recipe as it relates to the software version?

@jakerye
Copy link
Contributor Author

jakerye commented Aug 20, 2018

I think we wanted to add the field "sw_version_at_creation" to the recipe header to be used just for tracking purposes in case we make an incompatible change to the code base at a specific version in the future

@rbaynes rbaynes modified the milestones: v0.1.0 sprint, v0.2.0 sprint Sep 4, 2018
@jakerye jakerye added enhancement New feature or request urgent Mission critical fix immediately labels Sep 17, 2018
@jakerye jakerye mentioned this issue Sep 17, 2018
Closed
@jakerye
Copy link
Contributor Author

jakerye commented Sep 26, 2018

this was solved in PR #130

@jakerye jakerye closed this as completed Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rbaynes rbaynes

Labels
enhancement New feature or request urgent Mission critical fix immediately
Projects
None yet
Milestone
v1.0.1 feature freeze
Development

No branches or pull requests
2 participants
@jakerye @rbaynes