Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events #130

Merged
merged 32 commits into from
Sep 24, 2018
Merged

Events #130

merged 32 commits into from
Sep 24, 2018

Conversation

jakerye
Copy link
Contributor

@jakerye jakerye commented Sep 24, 2018

fixes #106

Copy link
Contributor

@rbaynes rbaynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you recursively make all files executable?

@jakerye
Copy link
Contributor Author

jakerye commented Sep 24, 2018

yeah....i got annoyed with a bunch of file level permission errors on my machine so i may have gotten a little carried away with assigning permissions........

Copy link
Contributor

@rbaynes rbaynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove data/config/develop

@rbaynes
Copy link
Contributor

rbaynes commented Sep 24, 2018

Looks good Jake, I'll have to run this for a while to make sure.

@jakerye jakerye merged commit 5460c3c into master Sep 24, 2018
@jakerye jakerye deleted the events branch September 24, 2018 18:12
@jakerye jakerye mentioned this pull request Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rework events system to be more robust
2 participants