Fix vehicles getting stuck in cityscape #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generated a significantly large UFO incursion with debug and no stuck vehicles there either |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I finally narrowed this problem down. The vehicle was attempting to sidestep to another location when it had 0 tickstoturn. Since it was trying to turn but couldn't, this froze the vehicle in place. This checks if tickstoturn is over 0 before sidestepping. I will admit that I can't test every situation that could happen so this could have unforeseen consequences. I have included the save I was using to test, it is a gigantic firefight. One or more vehicles would get stuck every other time I played on average before the fix. So far the fix has stopped any vehicles from getting stuck for 30 plus playthroughs of the fight.
save_stucktest.zip