Ask if uses want to overwrite save file when creating save with existing name #1371
Conversation
game/ui/general/savemenu.cpp
Outdated
| } | ||
| } | ||
|
|
||
| void SaveMenu::askUserIfWantToOverrideSavedGame(sp<SaveMetadata> saveMetadata) | ||
| { | ||
| auto saveName = saveMetadata->getName(); |
There was a problem hiding this comment.
Generally, if something can be const, I think it should be declared as such.
There was a problem hiding this comment.
You mean in the parameter, like this?
void SaveMenu::askUserIfWantToOverrideSavedGame(const sp<SaveMetadata> saveMetadata)| return !pathExists; | ||
| } | ||
|
|
||
| sp<SaveMetadata> SaveManager::getSaveGameIfExists(const UString &name) const |
There was a problem hiding this comment.
Not related to your change, as it's just following what's already there, but I really need to remove the sp<> wrapper here - it's not really a thing that needs shared ownership and arguably a bit unnecessary.
game/ui/general/savemenu.cpp
Outdated
| if (parent->Name == newSaveItemId) | ||
| { | ||
| if (saveManager.newSaveGame(saveName, currentState)) | ||
| auto saveGameMetadata = saveManager.getSaveGameIfExists(saveName); |
game/ui/general/savemenu.cpp
Outdated
| } | ||
| }); | ||
|
|
||
| std::function<void()> onNo = std::function<void()>([this] { clearTextEdit(activeTextEdit); }); |
There was a problem hiding this comment.
Can be auto? The type is already defined in the rhs
game/state/savemanager.cpp
Outdated
|
|
||
| sp<SaveMetadata> SaveManager::getSaveGameIfExists(const UString &name) const | ||
| { | ||
| auto saveList = getSaveList(); |
|
@JonnyH I added some more const values, let me know if I missed some. |
|
Thanks, looks good. I think c++ really should be "const-by-default", and force you to state if variables are mutable. I just find it makes it much easier to reason about code if you don't have to worry about variables changing :) |
ayrtondenner
deleted the
issue-1347-ask-if-overwrite-when-saving-file-with-same-name
branch
Fix #1347
After discussion in issue thread, I implemented the following logic:
I also encapsulated overwrite messagebox call in
SaveMenu::askUserIfWantToOverrideSavedGame