Add City Repair settings to More Options screen #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exceptional logic at saveLists() and loadLists() for More Options view
|
Tested and changed values for visual feedback confirmation All appears good, will merge this and leave #1319 open until a means to modify values is provided
|
ayrtondenner
deleted the
add-city-repair-to-more-options-settings-screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix addressing #1319
As you can see, this PR is just a partial fix since it does NOT allow the update of these settings values. But since this already adds a lot of updates, and since it seems that to complete this task it will be necessary to create a new form for numeric values - int and float - I decided to push this PR before doing any further work on this.
Obs.: I created lists to store settings name that are not bool, but either int or float. Please let me know if there's any better way to get these settings value instead.