Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix out of range message when out of ammo. #1417

Merged
merged 1 commit into from Apr 18, 2024

Conversation

Kurtsley
Copy link
Contributor

Addresses #1323

This should fix this issue. The logic is:

If the weapon can't fire,
If the weapon isn't empty,
if the weapon is a launcher, no arc
else out of range.

This means the weapon will never display these other messages if out of ammo. Is this OG?

I find this situation difficult to test, so I can't tell if this will break other things.

@FilmBoy84
Copy link
Collaborator

This was indeed a sod to replicate 🤣

But have achieved in modding by making a weapon that had a burst fire mode with the "wrong" multiple of ammo in the clip and an arcing projectile

Appears to work so merging

@FilmBoy84 FilmBoy84 merged commit 978e0c5 into OpenApoc:master Apr 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants