Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional feature to show prefix for non-XCOM vehicles #1433

Merged

Conversation

ayrtondenner
Copy link
Contributor

@ayrtondenner ayrtondenner commented May 7, 2024

Resolves #1312 and finishes #1405

Added optional feature that, when enabled, will add "*" prefix when displaying name of non-X-COM vehicles in alert message. Default option value is true.

Function Vehicle::getFormattedVehicleNameForEventMessage(GameState &state) will add prefix when option is true and when vehicle owner is not the player.

More Options view:
image

X-COM vehicle attacking construction vehicle:
destroyed-by

X-COM vehicle being attacked by enemy vehicle:
destroyed-by-2
image

@FilmBoy84
Copy link
Collaborator

Works nicely, appears in message ticker and message list as intended

image

Only noticeable thing is that it displays the prefix for UFOs that are destroyed but not for crashes or spot
image

I guess this could be explained as it's an "Unidentified Flying Object" until it's downed where the message then displays the craft type and prefixes it

Nonetheless, something probably for future debate and maybe a PR as this works and is a requested feature

Merging

@FilmBoy84 FilmBoy84 merged commit fb7282e into OpenApoc:master May 7, 2024
3 checks passed
@ayrtondenner ayrtondenner deleted the issue-1312-optional-xcom-vehicle-id branch May 7, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants