Use fmtlib instead of tinyformat #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use version 7.0.1, as that's the latest tag at this time
In some places (e.g. the sound backend) we have more useful paths, in others cast to void* first, so avoid possible confusion with custom typed formatters
TODO: Move to the indexed formatting strings for fmtlib
This works around things (E.g. the fmtlib api) that expect UniChar to be an encoded character, while we always just treat it as an integer codepoint Hopefully this can be removed completely (along with much of the UString class itself) when c++20 char8_t and std::basic_string<char8_t> actually define a 'utf8 encoded string'.
%I format specifier isn't supported by 'fmt'
"%s" should only be used for string-like types, %d for integers and %f for floats. Causes exceptions when fmt is being used instead of tinyformat (which would silently ignore these?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards using fmt's new indexed format string API (e.g. "thing: {1} {2}" instead of "thing: %s %s"). Though it still uses the printf-compatible formats for now, at least the fmt library can support both in parallel, allowing us to phase over.
This then is more consistent with boost::locale's formatting API, which is the longterm goal to allow reorder-able translate-able strings in code.
Plus, fmt is proposed to be in c++20 (and accepted - for now :) - so likely to be more 'standard' and 'expected' in c++ going forward (and may even allow us to drop a non-standard-library dependency eventually)