Pick up date from SOURCE_DATE_EPOCH, for reproducible builds #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal of reproducible builds is that a rebuild of the same source code with the same compiler, libraries, etc. should result in the same binaries. SOURCE_DATE_EPOCH provides a standard way for build systems to fill in the date of the latest source change, typically from a git commit or from metadata like the debian/changelog in Debian packages. This does not change anything if SOURCE_DATE_EPOCH is not defined; the intention is that a larger build system like a Debian package will define it. Please see https://reproducible-builds.org/ for more information about reproducible builds. Originally sent to ioquake3 as commit ioquake/ioq3@9c76b54 (which also touched engine files not present here). Signed-off-by: Simon McVittie <smcv@debian.org>
With a suitable setting for SOURCE_DATE_EPOCH, this makes building qagame.qvm reproducible too. Signed-off-by: Simon McVittie <smcv@debian.org>
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The goal of reproducible builds is that a rebuild of the same source code with the same compiler, libraries, etc. should result in the same binaries. SOURCE_DATE_EPOCH provides a standard way for build systems to fill in the date of the latest source change, typically from a git commit or from metadata like the debian/changelog in Debian packages.
This does not change anything if SOURCE_DATE_EPOCH is not defined; the intention is that a larger build system like a Debian package will define it.
Please see https://reproducible-builds.org/ for more information about reproducible builds.
Most of this pull request was sent to ioquake3 as commit ioquake/ioq3@9c76b54 (which also touched engine files not present here). This version also defines
PRODUCT_DATEwhen invokingq3lcc, makingqagame.qvmreproducible if a suitableSOURCE_DATE_EPOCHis provided.