Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests now that a missing trait is not an error #48

Closed
feltech opened this issue Sep 11, 2023 · 0 comments · Fixed by #49
Closed

Fix tests now that a missing trait is not an error #48

feltech opened this issue Sep 11, 2023 · 0 comments · Fixed by #49
Assignees
@feltech
Labels
bug Something isn't working

Comments

@feltech
Copy link
Member

feltech commented Sep 11, 2023

Fix tests since OpenAssetIO/OpenAssetIO#970
@feltech feltech mentioned this issue Sep 11, 2023
Merged
@feltech feltech self-assigned this Sep 11, 2023
@feltech feltech added the bug Something isn't working label Sep 11, 2023
@feltech feltech mentioned this issue Sep 11, 2023
Merged
feltech added a commit to feltech/OpenAssetIO-TraitGen that referenced this issue Sep 11, 2023
@feltech
[Tests] Fix tests now missing traits do not error
f709a14 
Closes OpenAssetIO#48.

In OpenAssetIO/OpenAssetIO#970 `TraitsData::getTraitProperty` was
updated such that an exception is no longer thrown when attempting to
retrieve a property of trait that is not imbued in the data.

This means the behaviour of the TraitGen view classes is now as
intended, finally.

So update the tests to reflect this.

Signed-off-by: David Feltell <david.feltell@foundry.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feltech feltech

Labels
bug Something isn't working
Projects
OpenAssetIO Development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tests now missing traits do not error feltech/OpenAssetIO-TraitGen
1 participant
@feltech