Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relationship compliancetest uses malformed reference as its skipped parameter #1022

Closed
elliotcmorris opened this issue Jul 23, 2023 · 0 comments · Fixed by #1046
Closed

Relationship compliancetest uses malformed reference as its skipped parameter #1022

elliotcmorris opened this issue Jul 23, 2023 · 0 comments · Fixed by #1046
Assignees
@elliotcmorris
Labels
test
Milestone
v1.0.0-beta.1.0

Comments

@elliotcmorris
Copy link
Contributor

elliotcmorris commented Jul 23, 2023 •
edited by foundrytom

What

Found this when updating the python manager template. The compliance suite tests for a malformed reference in Test_getWithRelationship_All uses the existence of a malformed entity reference fixture as the deciding factor as to whether it should be skipped. I propose it should be including whether the a_relationship_trait_set fixture exists either instead or in addition to this.

OpenAssetIO/src/openassetio-python/package/openassetio/test/manager/apiComplianceSuite.py

Line 686 in 3323a23

"a_malformed_reference", skipTestIfMissing=True

Why

The a_malformed_reference fixture is common to other non-optional flows, and is likely to be defined as a globally shared fixture, (which is what BAL does, really the only other example available, and bound to be copy-pasted,) This may give the wrong impression the the relationship functions must be implemented to a new implementer, and could bounce the tentative explorer.

Acceptance Criteria

  • Tests skipped based on relationship specific fixtures where possible.

Notes

  • Changes to BAL out of scope
@elliotcmorris elliotcmorris added invalid This doesn't seem right suggestion Something could be better and removed invalid This doesn't seem right labels Jul 23, 2023
@foundrytom foundrytom added this to the v1.0.0b1 milestone Aug 3, 2023
@foundrytom foundrytom added test and removed suggestion Something could be better labels Aug 3, 2023
@elliotcmorris elliotcmorris self-assigned this Aug 17, 2023
elliotcmorris added a commit to elliotcmorris/OpenAssetIO that referenced this issue Aug 17, 2023
@elliotcmorris
[Test] Alter which fixture skips relation tests
d0214ee 
OpenAssetIO#1022
Alter the skip fixture in certain getWithRelation tests away from
common shared ones  to the `a_relationship_trait_set`, which is
less likely to be defined in a shared context.

This is helpful because relationships are an optional feature, so it
is likely managers will want to skip all the relationship tests as a
group, and this makes that more or less the default behaviour without
thinking about it.

Signed-off-by: Elliot Morris <elliot.morris@foundry.com>
elliotcmorris added a commit to elliotcmorris/OpenAssetIO that referenced this issue Aug 17, 2023
@elliotcmorris
[Test] Alter which fixture skips relation tests
5006623 
OpenAssetIO#1022
Alter the skip fixture in certain getWithRelation tests away from
common shared ones  to the `a_relationship_trait_set`, which is
less likely to be defined in a shared context.

This is helpful because relationships are an optional feature, so it
is likely managers will want to skip all the relationship tests as a
group, and this makes that more or less the default behaviour without
thinking about it.

Signed-off-by: Elliot Morris <elliot.morris@foundry.com>
elliotcmorris added a commit to elliotcmorris/OpenAssetIO that referenced this issue Aug 17, 2023
@elliotcmorris
[Test] Alter which fixture skips relation tests
8dc7c6b 
OpenAssetIO#1022
Alter the skip fixture in certain getWithRelation tests away from
common shared ones  to the `a_relationship_trait_set`, which is
less likely to be defined in a shared context.

This is helpful because relationships are an optional feature, so it
is likely managers will want to skip all the relationship tests as a
group, and this makes that more or less the default behaviour without
thinking about it.

Signed-off-by: Elliot Morris <elliot.morris@foundry.com>
@elliotcmorris elliotcmorris mentioned this issue Aug 17, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elliotcmorris elliotcmorris

Labels
test
Projects
OpenAssetIO Development
Status: Done
Milestone
v1.0.0-beta.1.0
Development

Successfully merging a pull request may close this issue.

[Test] Alter which fixture skips relation tests elliotcmorris/OpenAssetIO
2 participants
@foundrytom @elliotcmorris