-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fmtlib dependency #1070
Comments
Added #1075 make broader use of fmtlib |
feltech
added a commit
to feltech/OpenAssetIO
that referenced
this issue
Sep 5, 2023
Closes OpenAssetIO#1070. fmtlib allows for easy, safe string substitution in C++, adding advanced formatting functionality (e.g. rounding), and reducing bloat. So add as a new private build-only header-only dependency. Using header-only increases compile times, but subjectively it's not noticeable, and has the benefit of avoiding a possible public library dependency (if OpenAssetIO is built as a static library). Tweak a single existing, tested, log string to make use of libfmt, to ensure basic usage is validated. Signed-off-by: David Feltell <david.feltell@foundry.com>
feltech
added a commit
to feltech/OpenAssetIO
that referenced
this issue
Sep 5, 2023
Closes OpenAssetIO#1070. fmtlib allows for easy, safe string substitution in C++, adding advanced formatting functionality (e.g. rounding), and reducing bloat. So add as a new private build-only header-only dependency. Using header-only increases compile times, but subjectively it's not noticeable, and has the benefit of avoiding a possible public library dependency (if OpenAssetIO is built as a static library). Tweak a single existing, tested, log string to make use of libfmt, to ensure basic usage is validated. Signed-off-by: David Feltell <david.feltell@foundry.com>
feltech
added a commit
to feltech/OpenAssetIO
that referenced
this issue
Sep 5, 2023
Closes OpenAssetIO#1070. fmtlib allows for easy, safe string substitution in C++, adding advanced formatting functionality (e.g. rounding), and reducing bloat. So add as a new private build-only header-only dependency. Using header-only increases compile times, but subjectively it's not noticeable, and has the benefit of avoiding a possible public library dependency (if OpenAssetIO is built as a static library). Tweak a single existing, tested, log string to make use of libfmt, to ensure basic usage is validated. Signed-off-by: David Feltell <david.feltell@foundry.com>
feltech
added a commit
to feltech/OpenAssetIO
that referenced
this issue
Sep 5, 2023
Closes OpenAssetIO#1070. fmtlib allows for easy, safe string substitution in C++, adding advanced formatting functionality (e.g. rounding), and reducing bloat. So add as a new private build-only header-only dependency. Using header-only increases compile times, but subjectively it's not noticeable, and has the benefit of avoiding a possible public library dependency (if OpenAssetIO is built as a static library). Tweak a single existing, tested, log string to make use of libfmt, to ensure basic usage is validated. Signed-off-by: David Feltell <david.feltell@foundry.com>
feltech
added a commit
to feltech/OpenAssetIO
that referenced
this issue
Sep 5, 2023
Closes OpenAssetIO#1070. fmtlib allows for easy, safe string substitution in C++, adding advanced formatting functionality (e.g. rounding), and reducing bloat. So add as a new private build-only header-only dependency. Using header-only increases compile times, but subjectively it's not noticeable, and has the benefit of avoiding a possible public library dependency (if OpenAssetIO is built as a static library). Tweak a single existing, tested, log string to make use of libfmt, to ensure basic usage is validated. Signed-off-by: David Feltell <david.feltell@foundry.com>
Posted upstream re. unexpected forcibly exported symbol: fmtlib/fmt#3626 |
feltech
added a commit
to feltech/OpenAssetIO
that referenced
this issue
Sep 7, 2023
Closes OpenAssetIO#1070. fmtlib allows for easy, safe string substitution in C++, adding advanced formatting functionality (e.g. rounding), and reducing bloat. So add as a new private build-only header-only dependency. Using header-only increases compile times, but subjectively it's not noticeable, and has the benefit of avoiding a possible public library dependency (if OpenAssetIO is built as a static library). Tweak a single existing, tested, log string to make use of libfmt, to ensure basic usage is validated. Signed-off-by: David Feltell <david.feltell@foundry.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What
Add fmtlib (private) dependency.
Why
fmt allows for easy, safe string substitution in C++, adding advanced formatting functionality (e.g. rounding), and reducing bloat, e.g.
Formatting user-defined types can be added in a variety of ways with fmt. Perhaps most portable is operator<< support.
However, fmt already supports several types, including container types, out of the box, so hooks for custom types might not be necessary at this point.
ACs
TraitSet
)Out of scope
The text was updated successfully, but these errors were encountered: