Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC 08: setRelatedReferences should be add and remove #16

Closed
foundrytom opened this issue Sep 22, 2021 · 1 comment
Closed

RFC 08: setRelatedReferences should be add and remove #16

foundrytom opened this issue Sep 22, 2021 · 1 comment
Labels
api change rfc
Milestone
v1.0.0 - Essential

Comments

@foundrytom
Copy link
Collaborator

foundrytom commented Sep 22, 2021 •
edited by elliotcmorris

What

Replace setRelatedReferences with addRelatedReferences and removeRelatedReferences.

NOTE: This is an old ticket, We should investigate whether add/remove is needed at all.

Why

It was highlighted that hard set updates in mult-tennanted APIs, especially with lists, are prime candidates for race condition issues.
@foundrytom foundrytom added the rfc label Sep 22, 2021
@foundrytom foundrytom added this to the Python core stable milestone Sep 22, 2021
@foundrytom foundrytom changed the title RFC 08: setEntityReferences should be add and remove RFC 08: setRelatedReferences should be add and remove Sep 27, 2021
@feltech feltech mentioned this issue Nov 9, 2021
Merged
This was referenced Apr 13, 2023
Closed
Open
Merged
elliotcmorris pushed a commit that referenced this issue Apr 20, 2023
@foundrytom @elliotcmorris
[Core] Remove setRelatedReferences
edfd1e2 
Part of #16.

`set` was not well considered, as it has the potential for race
conditions in real-world scenarios. A re-design is in the works, so
remove for now to avoid dead code in the release.

Signed-off-by: Tom Cowland <tom@foundry.com>
@foundrytom foundrytom modified the milestones: v1.0.0b1, v1.0.0 Jul 26, 2023
@elliotcmorris
Copy link
Contributor

Closing as out of date.

Add/Remove is implicit as part of the access mode used for publishing.
Closing this ticket dosen't mean we're outright rejecting the concept, just that we're not planning to reconsider any time soon.

@elliotcmorris elliotcmorris closed this as not planned Won't fix, can't repro, duplicate, stale Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api change rfc
Projects
OpenAssetIO Development
Status: Done
Milestone
v1.0.0 - Essential
Development

No branches or pull requests
2 participants
@foundrytom @elliotcmorris