Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] resolve method host conveniences #849

Closed
Tracked by #848
elliotcmorris opened this issue Mar 23, 2023 · 0 comments · Fixed by #864
Closed
Tracked by #848

[C++] resolve method host conveniences #849

elliotcmorris opened this issue Mar 23, 2023 · 0 comments · Fixed by #864
Assignees
@feltech @elliotcmorris
Labels
convenience

Comments

@elliotcmorris
Copy link
Contributor

elliotcmorris commented Mar 23, 2023 •
edited by foundrytom

Implement host conveniences for Resolve for the C++ api.
Resolve exists already in the C++ api, so does not need porting or deep redesign.
Refer to #848 for criteria.

ACs

  • Tag definitions
  • Static Tags instances
  • Default to Return policy
  • C++ tests
@elliotcmorris elliotcmorris mentioned this issue Mar 23, 2023
Closed
@elliotcmorris elliotcmorris self-assigned this Mar 23, 2023
@feltech feltech self-assigned this Mar 24, 2023
feltech added a commit to feltech/OpenAssetIO that referenced this issue Mar 24, 2023
@feltech
[Core] Make BatchElementError copyable
f9e2720 
Part of OpenAssetIO#849. In preparation for assigning `BatchElementError` objects
to each other (e.g. setting in a container), we must ensure its members
are not `const`.

Signed-off-by: David Feltell <david.feltell@foundry.com>
feltech added a commit to feltech/OpenAssetIO that referenced this issue Mar 28, 2023
@feltech
[Core] Add resolve convenience overloads
058e388 
Closes OpenAssetIO#849. Previously, the only interface to `resolve` assumed a
batch of entity references with success/error callbacks executed for
each element. This is somewhat clunky when only resolving a single
reference in particular, and requires significant boilerplate.

So add convenience overloads that present the API in a friendlier and
more versatile manner.

As resolve conveniences in C++ and Python are going to be somewhat
distinct, add C++ tests to verify behaviour of `variant` and exception
error modes.

Signed-off-by: David Feltell <david.feltell@foundry.com>
@feltech feltech mentioned this issue Mar 28, 2023
Merged
elliotcmorris pushed a commit to feltech/OpenAssetIO that referenced this issue Mar 30, 2023
@feltech @elliotcmorris
[Core] Make BatchElementError copyable
0c20bf2 
Part of OpenAssetIO#849. In preparation for assigning `BatchElementError` objects
to each other (e.g. setting in a container), we must ensure its members
are not `const`.

Signed-off-by: David Feltell <david.feltell@foundry.com>
elliotcmorris pushed a commit to feltech/OpenAssetIO that referenced this issue Mar 30, 2023
@feltech @elliotcmorris
[Core] Add resolve convenience overloads
6783626 
Closes OpenAssetIO#849. Previously, the only interface to `resolve` assumed a
batch of entity references with success/error callbacks executed for
each element. This is somewhat clunky when only resolving a single
reference in particular, and requires significant boilerplate.

So add convenience overloads that present the API in a friendlier and
more versatile manner.

As resolve conveniences in C++ and Python are going to be somewhat
distinct, add C++ tests to verify behaviour of `variant` and exception
error modes.

Signed-off-by: David Feltell <david.feltell@foundry.com>
@feltech feltech mentioned this issue Mar 30, 2023
Merged
2 tasks
elliotcmorris pushed a commit to feltech/OpenAssetIO that referenced this issue Mar 31, 2023
@feltech @elliotcmorris
[Core] Make BatchElementError copyable
fa54bf8 
Part of OpenAssetIO#849. In preparation for assigning `BatchElementError` objects
to each other (e.g. setting in a container), we must ensure its members
are not `const`.

Signed-off-by: David Feltell <david.feltell@foundry.com>
elliotcmorris pushed a commit to feltech/OpenAssetIO that referenced this issue Mar 31, 2023
@feltech @elliotcmorris
[Core] Add resolve convenience overloads
e0766f3 
Closes OpenAssetIO#849. Previously, the only interface to `resolve` assumed a
batch of entity references with success/error callbacks executed for
each element. This is somewhat clunky when only resolving a single
reference in particular, and requires significant boilerplate.

So add convenience overloads that present the API in a friendlier and
more versatile manner.

As resolve conveniences in C++ and Python are going to be somewhat
distinct, add C++ tests to verify behaviour of `variant` and exception
error modes.

Signed-off-by: David Feltell <david.feltell@foundry.com>
elliotcmorris pushed a commit to feltech/OpenAssetIO that referenced this issue Apr 3, 2023
@feltech @elliotcmorris
[Core] Make BatchElementError copyable
7a2c178 
Part of OpenAssetIO#849. In preparation for assigning `BatchElementError` objects
to each other (e.g. setting in a container), we must ensure its members
are not `const`.

Signed-off-by: David Feltell <david.feltell@foundry.com>
elliotcmorris pushed a commit to feltech/OpenAssetIO that referenced this issue Apr 3, 2023
@feltech @elliotcmorris
[Core] Add resolve convenience overloads
30eff72 
Closes OpenAssetIO#849. Previously, the only interface to `resolve` assumed a
batch of entity references with success/error callbacks executed for
each element. This is somewhat clunky when only resolving a single
reference in particular, and requires significant boilerplate.

So add convenience overloads that present the API in a friendlier and
more versatile manner.

As resolve conveniences in C++ and Python are going to be somewhat
distinct, add C++ tests to verify behaviour of `variant` and exception
error modes.

Signed-off-by: David Feltell <david.feltell@foundry.com>
@foundrytom foundrytom mentioned this issue Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feltech feltech

@elliotcmorris elliotcmorris

Labels
convenience
Projects
OpenAssetIO Development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

C++ resolve method host conveniences feltech/OpenAssetIO
3 participants
@feltech @foundrytom @elliotcmorris