Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manager.createChildContext should deep-copy the locale #896

Closed
foundrytom opened this issue Apr 17, 2023 · 0 comments · Fixed by #900
Closed

Manager.createChildContext should deep-copy the locale #896

foundrytom opened this issue Apr 17, 2023 · 0 comments · Fixed by #900
Assignees
@foundrytom
Labels
api change
Milestone
v1.0.0-beta.1.0

Comments

@foundrytom
Copy link
Collaborator

foundrytom commented Apr 17, 2023 •
edited

What

createChildContext should copy the locale vs sharing.

Why

This method is used to create 'related but detached' contexts, sharing a locale couples them

Acceptance Criteria

  • The new child context does not share any ptr-referenced properties with the parent context (aside from the managerState).
  • The new context has a locale equal to the parent.

Out of scope

  • New host documentation
@foundrytom foundrytom added this to the Core stable milestone Apr 17, 2023
@foundrytom foundrytom self-assigned this Apr 18, 2023
foundrytom added a commit to foundrytom/OpenAssetIO that referenced this issue Apr 18, 2023
@foundrytom
[Core] Deep-copy locale in Manager.createChildContext
f93fdec 
`createChildContext` is meant to produce a new context that is
associated with the parent. Speicifcally, for when you wish to modify an
existing context in paralell. Sharing a locale (as we were only copying
the ptr) meant that modifing the locale in one would update the locale
in another. This is confusing and undesirable.

Now the locale `TraitsData` is deep-copied.

Closes OpenAssetIO#896

Signed-off-by: Tom Cowland <tom@foundry.com>
@foundrytom foundrytom mentioned this issue Apr 18, 2023
Merged
foundrytom added a commit to foundrytom/OpenAssetIO that referenced this issue Apr 18, 2023
@foundrytom
[Core] Deep-copy locale in Manager.createChildContext
0b503e0 
`createChildContext` is meant to produce a new context that is
associated with the parent. Speicifcally, for when you wish to modify an
existing context in paralell. Sharing a locale (as we were only copying
the ptr) meant that modifing the locale in one would update the locale
in another. This is confusing and undesirable.

Now the locale `TraitsData` is deep-copied.

Closes OpenAssetIO#896

Signed-off-by: Tom Cowland <tom@foundry.com>
foundrytom added a commit to foundrytom/OpenAssetIO that referenced this issue Apr 18, 2023
@foundrytom
[Core] Deep-copy locale in Manager.createChildContext
8ecd050 
`createChildContext` is meant to produce a new context that is
associated with the parent. Speicifcally, for when you wish to modify an
existing context in paralell. Sharing a locale (as we were only copying
the ptr) meant that modifing the locale in one would update the locale
in another. This is confusing and undesirable.

Now the locale `TraitsData` is deep-copied.

Closes OpenAssetIO#896

Signed-off-by: Tom Cowland <tom@foundry.com>
foundrytom added a commit to foundrytom/OpenAssetIO that referenced this issue Apr 18, 2023
@foundrytom
[Core] Deep-copy locale in Manager.createChildContext
7a50684 
`createChildContext` is meant to produce a new context that is
associated with the parent. Speicifcally, for when you wish to modify an
existing context in paralell. Sharing a locale (as we were only copying
the ptr) meant that modifing the locale in one would update the locale
in another. This is confusing and undesirable.

Now the locale `TraitsData` is deep-copied.

Closes OpenAssetIO#896

Signed-off-by: Tom Cowland <tom@foundry.com>
foundrytom added a commit to foundrytom/OpenAssetIO that referenced this issue Apr 18, 2023
@foundrytom
[Core] Deep-copy locale in Manager.createChildContext
b8f46c0 
`createChildContext` is meant to produce a new context that is
associated with the parent. Speicifcally, for when you wish to modify an
existing context in paralell. Sharing a locale (as we were only copying
the ptr) meant that modifing the locale in one would update the locale
in another. This is confusing and undesirable.

Now the locale `TraitsData` is deep-copied.

Closes OpenAssetIO#896

Signed-off-by: Tom Cowland <tom@foundry.com>
foundrytom added a commit to foundrytom/OpenAssetIO that referenced this issue Apr 19, 2023
@foundrytom
[Core] Deep-copy locale in Manager.createChildContext
c34f55d 
`createChildContext` is meant to produce a new context that is
associated with the parent. Speicifcally, for when you wish to modify an
existing context in paralell. Sharing a locale (as we were only copying
the ptr) meant that modifing the locale in one would update the locale
in another. This is confusing and undesirable.

Now the locale `TraitsData` is deep-copied.

Closes OpenAssetIO#896

Signed-off-by: Tom Cowland <tom@foundry.com>
elliotcmorris pushed a commit to foundrytom/OpenAssetIO that referenced this issue Apr 20, 2023
@foundrytom @elliotcmorris
[Core] Deep-copy locale in Manager.createChildContext
c405564 
`createChildContext` is meant to produce a new context that is
associated with the parent. Speicifcally, for when you wish to modify an
existing context in paralell. Sharing a locale (as we were only copying
the ptr) meant that modifing the locale in one would update the locale
in another. This is confusing and undesirable.

Now the locale `TraitsData` is deep-copied.

Closes OpenAssetIO#896

Signed-off-by: Tom Cowland <tom@foundry.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@foundrytom foundrytom

Labels
api change
Projects
OpenAssetIO Development
Status: Done
Milestone
v1.0.0-beta.1.0
Development

Successfully merging a pull request may close this issue.

Deep-copy locale in createChildContext foundrytom/OpenAssetIO
1 participant
@foundrytom