Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getRelationship[s] coverage to apiComplianceSuite #914

Closed
foundrytom opened this issue May 3, 2023 · 0 comments · Fixed by #952
Closed

Add getRelationship[s] coverage to apiComplianceSuite #914

foundrytom opened this issue May 3, 2023 · 0 comments · Fixed by #952
Assignees

Comments

@foundrytom
Copy link
Collaborator

No description provided.

@foundrytom foundrytom added this to the Core stable milestone May 3, 2023
@foundrytom foundrytom self-assigned this May 22, 2023
foundrytom added a commit to foundrytom/OpenAssetIO that referenced this issue Jun 5, 2023
Adds basic coverage for the relationship query methods. Note: this has
deliberately been left in it's somewhat long-winded form, as it hints
that we may well want to look at a bit of a refactor of the harness, now
its being used at scale.

Closes OpenAssetIO#914

Signed-off-by: Tom Cowland <tom@foundry.com>
foundrytom added a commit to foundrytom/OpenAssetIO that referenced this issue Jun 5, 2023
Adds basic coverage for the relationship query methods. Note: this has
deliberately been left in it's somewhat long-winded form, as it hints
that we may well want to look at a bit of a refactor of the harness, now
its being used at scale.

Closes OpenAssetIO#914

Signed-off-by: Tom Cowland <tom@foundry.com>
foundrytom added a commit to foundrytom/OpenAssetIO that referenced this issue Jun 20, 2023
Adds basic coverage for the relationship query methods. Note: this has
deliberately been left in it's somewhat long-winded form, as it hints
that we may well want to look at a bit of a refactor of the harness, now
its being used at scale.

Closes OpenAssetIO#914

Signed-off-by: Tom Cowland <tom@foundry.com>
feltech added a commit to foundrytom/OpenAssetIO that referenced this issue Jun 20, 2023
Closes OpenAssetIO#914. Possible now that OpenAssetIO/OpenAssetIO-Manager-BAL#47
has updated BAL to use the new signatures for `getWithRelationship[s]`

Signed-off-by: David Feltell <david.feltell@foundry.com>
feltech added a commit to foundrytom/OpenAssetIO that referenced this issue Jun 22, 2023
In support of OpenAssetIO#914 (and beyond), add a couple of useful utility methods
for test cases in the `apiComplianceSuite` test harness.

Specifically, `requireEntityReferenceFixture` and
`requireEntityReferencesFixture` convert a string fixture into an
`EntityReference` object, or a list-of-strings fixture into a list of
`EntityReference` objects, respectively.

Signed-off-by: David Feltell <david.feltell@foundry.com>
feltech pushed a commit to foundrytom/OpenAssetIO that referenced this issue Jun 22, 2023
Closes OpenAssetIO#914

Adds basic coverage for the relationship query methods.

Rather than getting tripped up by coming up with good unambiguous names
for fixtures, re-use similar names by namespacing the fixtures under
their test name, i.e. rather than using `"shared"` fixtures.

Signed-off-by: David Feltell <david.feltell@foundry.com>
feltech added a commit to foundrytom/OpenAssetIO that referenced this issue Jun 22, 2023
In support of OpenAssetIO#914 (and beyond), add a couple of useful utility methods
for test cases in the `apiComplianceSuite` test harness.

Specifically, `requireEntityReferenceFixture` and
`requireEntityReferencesFixture` convert a string fixture into an
`EntityReference` object, or a list-of-strings fixture into a list of
`EntityReference` objects, respectively.

Signed-off-by: David Feltell <david.feltell@foundry.com>
feltech pushed a commit to foundrytom/OpenAssetIO that referenced this issue Jun 22, 2023
Closes OpenAssetIO#914

Adds basic coverage for the relationship query methods.

Rather than getting tripped up by coming up with good unambiguous names
for fixtures, re-use similar names by namespacing the fixtures under
their test name, i.e. rather than using `"shared"` fixtures.

Signed-off-by: David Feltell <david.feltell@foundry.com>
feltech pushed a commit to foundrytom/OpenAssetIO that referenced this issue Jun 26, 2023
Closes OpenAssetIO#914

Adds basic coverage for the relationship query methods.

Rather than getting tripped up by coming up with good unambiguous names
for fixtures, re-use similar names by namespacing the fixtures under
their test name, i.e. rather than using `"shared"` fixtures.

Signed-off-by: David Feltell <david.feltell@foundry.com>
feltech added a commit to foundrytom/OpenAssetIO that referenced this issue Jun 26, 2023
In support of OpenAssetIO#914 (and beyond), add a couple of useful utility methods
for test cases in the `apiComplianceSuite` test harness.

Specifically, `requireEntityReferenceFixture` and
`requireEntityReferencesFixture` convert a string fixture into an
`EntityReference` object, or a list-of-strings fixture into a list of
`EntityReference` objects, respectively.

Signed-off-by: David Feltell <david.feltell@foundry.com>
feltech pushed a commit to foundrytom/OpenAssetIO that referenced this issue Jun 26, 2023
Closes OpenAssetIO#914

Adds basic coverage for the relationship query methods.

Rather than getting tripped up by coming up with good unambiguous names
for fixtures, re-use similar names by namespacing the fixtures under
their test name, i.e. rather than using `"shared"` fixtures.

Signed-off-by: David Feltell <david.feltell@foundry.com>
feltech pushed a commit to foundrytom/OpenAssetIO that referenced this issue Jun 26, 2023
Closes OpenAssetIO#914

Adds basic coverage for the relationship query methods.

Rather than getting tripped up by coming up with good unambiguous names
for fixtures, re-use similar names by namespacing the fixtures under
their test name, i.e. rather than using `"shared"` fixtures.

Signed-off-by: David Feltell <david.feltell@foundry.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant