Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate constants.py to C++ #998

Closed
Tracked by #897
foundrytom opened this issue Jul 3, 2023 · 0 comments · Fixed by #1007
Closed
Tracked by #897

Migrate constants.py to C++ #998

foundrytom opened this issue Jul 3, 2023 · 0 comments · Fixed by #1007
Assignees
@feltech

Comments

@foundrytom
Copy link
Collaborator

foundrytom commented Jul 3, 2023 •
edited

What

Migrate to C++ in a backwards-compatible way.
Rename kField to kInfoKey w/ deprecation in python only
remove constants.py and dont worry about other constants in there
This was referenced Jul 3, 2023
Open
Merged
@feltech feltech self-assigned this Jul 6, 2023
feltech added a commit to feltech/OpenAssetIO that referenced this issue Jul 6, 2023
@feltech
[Core] Migrate constants to C++
8b92c32 
Closes OpenAssetIO#998. C++ hosts and managers will need a shared understanding of
common manager info dictionary keys.

In particular, upcoming work will implement the
`isEntityReferenceString` prefix optimisation (OpenAssetIO#566).

Signed-off-by: David Feltell <david.feltell@foundry.com>
@feltech feltech mentioned this issue Jul 6, 2023
Merged
2 tasks
feltech added a commit to feltech/OpenAssetIO that referenced this issue Jul 6, 2023
@feltech
[Core] Migrate constants to C++
0863cff 
Closes OpenAssetIO#998. C++ hosts and managers will need a shared understanding of
common manager info dictionary keys.

In particular, upcoming work will implement the
`isEntityReferenceString` prefix optimisation (OpenAssetIO#566).

Signed-off-by: David Feltell <david.feltell@foundry.com>
feltech added a commit to feltech/OpenAssetIO that referenced this issue Jul 6, 2023
@feltech
[Core] Migrate constants to C++
a3082a4 
Closes OpenAssetIO#998. C++ hosts and managers will need a shared understanding of
common manager info dictionary keys.

In particular, upcoming work will implement the
`isEntityReferenceString` prefix optimisation (OpenAssetIO#566).

Signed-off-by: David Feltell <david.feltell@foundry.com>
feltech added a commit to feltech/OpenAssetIO that referenced this issue Jul 6, 2023
@feltech
[Core] Migrate constants to C++
21fe32a 
Closes OpenAssetIO#998. C++ hosts and managers will need a shared understanding of
common manager info dictionary keys.

In particular, upcoming work will implement the
`isEntityReferenceString` prefix optimisation (OpenAssetIO#566).

Signed-off-by: David Feltell <david.feltell@foundry.com>
This was referenced Jul 6, 2023
Closed
Closed
feltech added a commit to feltech/OpenAssetIO that referenced this issue Jul 7, 2023
@feltech
[Core] Migrate constants to C++
6a2093b 
Closes OpenAssetIO#998. C++ hosts and managers will need a shared understanding of
common manager info dictionary keys.

In particular, upcoming work will implement the
`isEntityReferenceString` prefix optimisation (OpenAssetIO#566).

Signed-off-by: David Feltell <david.feltell@foundry.com>
@feltech feltech mentioned this issue Jul 12, 2023
Merged
feltech added a commit to feltech/OpenAssetIO-Manager-BAL that referenced this issue Jul 12, 2023
@feltech
[Tests] Fix OpenAssetIO constants import
cdf8a80 
In OpenAssetIO/OpenAssetIO#998 the `constants` module was migrated to
C++ as a CPython submodule. This means, annoyingly, that we can no
longer import objects `from` the `constants` module. Instead, we must
import the `constants` module wholesale.

Signed-off-by: David Feltell <david.feltell@foundry.com>
feltech added a commit to feltech/OpenAssetIO that referenced this issue Jul 13, 2023
@feltech
[Docs] Breaking change release note for constants import
ac8119f 
In OpenAssetIO#998 the `openassetio.constants` pure-Python module was migrated to a
CPython submodule (`_openassetio.constants`), which has the unfortunate
side-effect of no longer allowing the `import` of individual elements
inside the module (i.e. `from constants import <something>`).

So update the release notes to call that out as an additional breaking
change.

This was detected (and fixed) in BAL in
OpenAssetIO/OpenAssetIO-Manager-BAL#55

Signed-off-by: David Feltell <david.feltell@foundry.com>
@feltech feltech mentioned this issue Jul 13, 2023
Merged
@elliotcmorris elliotcmorris mentioned this issue Jul 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feltech feltech

Labels
None yet
Projects
OpenAssetIO Development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate constants to C++ feltech/OpenAssetIO
2 participants
@feltech @foundrytom