Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Increase verbosity of API compliance suite #1032

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

feltech
Copy link
Member

@feltech feltech commented Aug 8, 2023

Description

It's very easy for manager plugin authors to accidentally miss defining a fixture, causing a test to be skipped erroneously. With the default report, it is difficult to discern which tests were skipped.

So increase the verbosity, so that all tests are printed along with their status, including the reason given for skipping a test.

  • I have updated the release notes.
  • I have updated all relevant user documentation.

Reviewer Notes

This was highlighted when, on a hunch, I increased verbosity to find that BAL's fixtures file seems to be missing some definitions that should be there (see OpenAssetIO/OpenAssetIO-Manager-BAL#61). Hopefully permanently increasing verbosity will help prevent this in future.

Test Instructions

Run the API compliance suite against, say, BAL, and note that all test names are printed alongside their status.

@feltech feltech added enhancement New feature or request Python labels Aug 8, 2023
@feltech feltech self-assigned this Aug 8, 2023
@feltech feltech requested a review from a team as a code owner August 8, 2023 09:20
It's very easy for manager plugin authors to accidentally miss defining
a fixture, causing a test to be skipped erroneously. With the default
report, it is difficult to discern which tests were skipped.

So increase the verbosity, so that all tests are printed along with
their status, including the reason given for skipping a test.

Signed-off-by: David Feltell <david.feltell@foundry.com>
@feltech feltech force-pushed the work/verboseAPIComplianceReport branch from d2ce6c4 to 6466c27 Compare August 8, 2023 10:00
@feltech feltech merged commit 84aae85 into OpenAssetIO:main Aug 8, 2023
39 checks passed
@feltech feltech deleted the work/verboseAPIComplianceReport branch August 8, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Python
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants