TraitBase isImbued and isImbuedTo
#818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feltech
changed the title
TraitBase isImbued and isImbuedTo
foundrytom
requested changes
Feb 22, 2023
feltech
force-pushed
the
work/815-traitBaseIsValidImprovements
branch
from
a3aeeae
to
28d2303
Compare
Fixed in 28d2303 |
foundrytom
approved these changes
Feb 27, 2023
Part of OpenAssetIO#815. For symmetry with `imbue` and `imbueTo` methods, rename the `isValid` method to `isImbued.` Signed-off-by: David Feltell <david.feltell@foundry.com>
Closes OpenAssetIO#815. For C++ in particular, where performance is likely a concern, constructing a `TraitBase`-derived instance, just to check `isImbued`, is wasteful. So add a static `isImbuedTo` (for symmetry with `imbueTo`), which tests a `TraitsData` without unnecessary temporary construction. Signed-off-by: David Feltell <david.feltell@foundry.com>
feltech
force-pushed
the
work/815-traitBaseIsValidImprovements
branch
from
28d2303
to
9d5de0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #815
For symmetry with
imbueandimbueTomethods, rename theisValidmethod toisImbued.For C++ in particular, where performance is likely a concern, constructing a
TraitBase-derived instance, just to checkisImbued, is wasteful. So add a staticisImbuedTo(for symmetry withimbueTo), which tests aTraitsDatawithout unnecessary temporaryconstruction.