Fix clang-tidy v15 warnings

[feltech]

Although we have yet to move to the newer clang-tidy on CI, we aim to support devs using a newer clang-tidy than v12.

Test Instructions

We seem to be getting cross-platform differences coming from a std::rethrow_exception call in src/openassetio-python/cmodule/src/BatchElementErrorBinding.cpp. That is, MacOS gives a warning that the std::exception_ptr cannot be std::moved, for some reason. See also #867 (comment)

[foundrytom]

Just noting:

src/openassetio-core/include/openassetio/BatchElementError.hpp|48 col 7| error: an exception may be thrown in function 'BatchElementError' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors]
src/openassetio-core/include/openassetio/EntityReference.hpp|35 col 7| error: an exception may be thrown in function 'EntityReference' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors]
src/openassetio-core/include/openassetio/hostApi/ManagerFactory.hpp|43 col 10| error: an exception may be thrown in function 'ManagerDetail' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors]

On macOS which @feltech discovered as being llvm/llvm-project#54668.

[foundrytom]

Good fixes, thanks. We're no worse off on mac/etc than we were, so can tackle those in followups if you like. Do we need an Improvements entry in the release notes?

[feltech]

Good fixes, thanks. We're no worse off on mac/etc than we were, so can tackle those in followups if you like. Do we need an Improvements entry in the release notes?

Updated release notes in 3194a59