bugfix: coredump in ubuntu when it shutdown (#1151)

issue: #1152
OpenAtomFoundation · Mar 21, 2022 · 6a4baa6 · 6a4baa6
1 parent 5ea6a77
commit 6a4baa6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/include/pika_proxy_cli.h b/include/pika_proxy_cli.h
@@ -73,6 +73,7 @@ class ProxyCli : public std::enable_shared_from_this<ProxyCli> {
     std::shared_ptr<std::string> resp_ptr;
   };
   void LostConn(const std::string& ip_port);
+  ~ProxyCli();
 
  private:
   int cron_interval_;

diff --git a/src/pika_proxy_cli.cc b/src/pika_proxy_cli.cc
@@ -47,8 +47,6 @@ int ProxyCli::Start() {
 
 int ProxyCli::Stop() {
   client_ptr_->StopThread();
-  delete proxy_factory_;
-  delete proxy_handle_;
   return pink::kSuccess;
 }
 
@@ -154,3 +152,7 @@ void ProxyCli::LostConn(const std::string& ip_port) {
     delete proxy_task;
   }
 }
+ProxyCli::~ProxyCli() {
+  delete proxy_factory_;
+  delete proxy_handle_;
+}