Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【命名规范问题】PikaServer的TryDBSync函数与实际的功能不匹配，建议修改函数名 #2293

Closed
chengyu-l opened this issue Jan 10, 2024 · 0 comments
Closed

【命名规范问题】PikaServer的TryDBSync函数与实际的功能不匹配，建议修改函数名 #2293

chengyu-l opened this issue Jan 10, 2024 · 0 comments
Labels
☢️ Bug Something isn't working

Comments

@chengyu-l
Copy link
Contributor

Is this a regression?

Yes

Description

PikaServer的TryDBSync函数主要做的事情是做bgsaveslot，按照主从同步的概念，TryDBSync 容易让人联想到尝试发生DBSync请求（全量同步请求）。
image

image

Please provide a link to a minimal reproduction of the bug

No response

Screenshots or videos

No response

Please provide the version you discovered this bug in (check about page for version information)

No response

Anything else?

No response
@chengyu-l chengyu-l added the ☢️ Bug Something isn't working label Jan 10, 2024
chengyu-l pushed a commit to chengyu-l/pika that referenced this issue Jan 12, 2024
fix: return wrong response code when DBSync request SyncMasterSlot no…
f735c5a 
…t exist(OpenAtomFoundation#2290,  OpenAtomFoundation#2293)
chengyu-l pushed a commit to chengyu-l/pika that referenced this issue Jan 12, 2024
fix: return wrong response code when DBSync request SyncMasterSlot no…
acfc631 
…t exist(OpenAtomFoundation#2290,  OpenAtomFoundation#2293)
chengyu-l pushed a commit to chengyu-l/pika that referenced this issue Jan 12, 2024
fix: return wrong response code when DBSync request SyncMasterSlot no…
0a4ac4a 
…t exist(OpenAtomFoundation#2290, OpenAtomFoundation#2293)
@chengyu-l chengyu-l mentioned this issue Jan 12, 2024
Merged
AlexStocks pushed a commit that referenced this issue Jan 12, 2024
@chengyu-l
fix: return wrong response code when DBSync request SyncMasterSlot no…
59a5c30 
…t exist(#2290, #2293) (#2308)

Co-authored-by: liuchengyu <liuchengyu@360.cn>
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this issue Jun 8, 2024
@chengyu-l
fix: return wrong response code when DBSync request SyncMasterSlot no…
2f62ba4 
…t exist(OpenAtomFoundation#2290, OpenAtomFoundation#2293) (OpenAtomFoundation#2308)

Co-authored-by: liuchengyu <liuchengyu@360.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
☢️ Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chengyu-l