Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build depencies as external project #1281

Merged
merged 4 commits into from
Feb 20, 2023
Merged

build depencies as external project #1281

merged 4 commits into from
Feb 20, 2023

Conversation

kernelai
Copy link
Collaborator

to be done

@kernelai
Copy link
Collaborator Author

kernelai commented Feb 20, 2023 •
edited

can not add protobuf as external project. this is becasue protobuf_generate_cpp have to use find_package(Protobuf REQUIRED) before using . find_package can not add depency

@kernelai
Copy link
Collaborator Author

for compile jemalloc have to install autoconf

@kernelai kernelai added this to To Do in pika adapt environment for develop via automation Feb 20, 2023
@wanghenshui wanghenshui changed the title wip: build depencies as external project build depencies as external project Feb 20, 2023
wanghenshui
wanghenshui reviewed Feb 20, 2023
View reviewed changes
Copy link
Collaborator

@wanghenshui wanghenshui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghenshui wanghenshui merged commit b551dbf into OpenAtomFoundation:unstable Feb 20, 2023
pika adapt environment for develop automation moved this from To Do to Done Feb 20, 2023
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
@kernelai
build depencies as external project (OpenAtomFoundation#1281)
d7cfeac 
* wip: build depencies as external project

* feature: cmake compile dependency as external project

* feature: move external porject install DIR to deps

* format: remove blank line

---------

Co-authored-by: liuzhen3 <liuzhen3@360.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghenshui wanghenshui wanghenshui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
pika adapt environment for develop
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kernelai @wanghenshui