Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add libunwind as external project #1316

Merged
merged 6 commits into from
Mar 8, 2023

Conversation

kernelai
Copy link
Collaborator

@kernelai kernelai commented Mar 6, 2023

WIP, a ld bug need to fix

@kernelai
Copy link
Collaborator Author

kernelai commented Mar 8, 2023

done

@wanghenshui wanghenshui changed the title feature: add libunwind as external project build: add libunwind as external project Mar 8, 2023
@kernelai kernelai removed the request for review from machinly March 8, 2023 08:29
@wanghenshui
Copy link
Collaborator

unwind需要xz?

@kernelai
Copy link
Collaborator Author

kernelai commented Mar 8, 2023

ci 看起来需要lzma-dev,我在本地测试centos7 和ubuntu22.04的空环境都没问题。我再fix下。

@wanghenshui
Copy link
Collaborator

ci 看起来需要lzma-dev,我在本地测试centos7 和ubuntu22.04的空环境都没问题。我再fix下。

cmake加还是编译流水线workflow里加?

@kernelai
Copy link
Collaborator Author

kernelai commented Mar 8, 2023

libunwind 有个选项开关会依赖lzma 对符号表进行压缩,现在是关闭的。差异会是coredump的size会大一点。配置这个的依赖会麻烦一点,后面的pr再修复这个问题吧。

@wanghenshui wanghenshui merged commit c250203 into OpenAtomFoundation:unstable Mar 8, 2023
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants