fix: init every class member's value to defeat the redis-cli connection closed by pika #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is ready? |
AlexStocks
force-pushed
the
feature/issue1367
branch
from
af131bd
to
436647e
Compare
AlexStocks
changed the title
wanghenshui
approved these changes
Apr 24, 2023
| @@ -76,30 +78,36 @@ class NetConn : public std::enable_shared_from_this<NetConn> { | |||
|
|
|||
| NetMultiplexer* net_multiplexer() const { return net_multiplexer_; } | |||
|
|
|||
| std::string String() const { | |||
| @@ -20,13 +20,16 @@ class NetItem { | |||
|
|
|||
| int fd() const { return fd_; } | |||
| std::string ip_port() const { return ip_port_; } | |||
| std::string String() const { | |||
There was a problem hiding this comment.
ToString
我这个是借鉴 Go 的实现，ToString() 是 Java 的吗？
There was a problem hiding this comment.
额接口名字而已，String也行，别的库基本都是ToString ToStringView to_string to_stringview 这几类
wanghenshui
changed the title
loveyacper
reviewed
Apr 24, 2023
loveyacper
reviewed
Apr 24, 2023
lqxhub
approved these changes
Apr 24, 2023
|
@loveyacper Pls check it again. thx. |
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
…on closed by pika (OpenAtomFoundation#1390) * update version * fix bug: wrong buffer size in vsnprintf * fix holyThread close fd bug * handle ewouldblock error * add output macro * init NetConn & RedisConn & ClientConn members' value in its class * delete output macro * delete ks.sh * reformat output macro * init NetConn & RedisConn & ClientConn members' value in its class * add connection log * recove GetTestDirectory * do not init non-POD obj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1367 : server 与 client 之间间歇性断开问题 https://github.com/OpenAtomFoundation/pika/issues/1367#issuecomment-1518607186。
问题代码所在：
这里构造函数，没见啥地方初始化 close_ 字段的值，但是它的值为 true。原因就在于 C++ 中如果不给变量初始化值，其值未定义，为 true 还是为 false 都有可能。
解决方法：在 class 中初始化成员变量的值。