feat: add spop by count #1434
Merged
feat: add spop by count #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanghenshui
reviewed
May 5, 2023
| @@ -424,6 +424,9 @@ class Storage { | |||
| // Removes and returns one random elements from the set value store at key. | |||
| Status SPop(const Slice& key, std::string* member); | |||
|
|
|||
| // Removes and returns several random elements specified by count from the set value store at key. | |||
| Status SPop(const Slice& key, std::vector<std::string>* members, int64_t count); | |||
There was a problem hiding this comment.
ok，那set test里面也需要修改了。
There was a problem hiding this comment.
ok，那set test里面也需要修改了。
嗯，你一块改了就行。另外里面那个50那个magic值，最好能导出来
There was a problem hiding this comment.
ok，那set test里面也需要修改了。
嗯，你一块改了就行。另外里面那个50那个magic值，最好能导出来
导出来啥意思?
There was a problem hiding this comment.
ok，那set test里面也需要修改了。
嗯，你一块改了就行。另外里面那个50那个magic值，最好能导出来
导出来啥意思?
最好可配置
There was a problem hiding this comment.
ok，那set test里面也需要修改了。
嗯，你一块改了就行。另外里面那个50那个magic值，最好能导出来
导出来啥意思?
最好可配置
这个可以建个 issue，后续推进吧。
|
你的实现有问题，你看上面例子，redis 是允许 count 大于 set 里面 member 个数的 |
AlexStocks
reviewed
May 5, 2023
AlexStocks
reviewed
May 5, 2023
AlexStocks
reviewed
May 5, 2023
…p-count get latest update version
|
改动点： |
|
改动的已经commit了，等待review |
AlexStocks
reviewed
May 8, 2023
…p-count pull updated changes
AlexStocks
approved these changes
May 8, 2023
|
ping @wanghenshui |
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #889:
redis API: spop with count.