delete_sharding_command cluster_info&&slot_command #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luky116
reviewed
May 11, 2023
| @@ -190,24 +190,6 @@ const std::string kCmdNamePubSub = "pubsub"; | |||
| const std::string kCmdNamePSubscribe = "psubscribe"; | |||
| const std::string kCmdNamePUnSubscribe = "punsubscribe"; | |||
|
|
|||
| // Codis Slots | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
具体是指的codis干啥用的, 我理解主从复制模式只有一个slot，根本不需要这些命令。
There was a problem hiding this comment.
还有主从复制为什么要适配codis，主从复制我理解不需要codis
There was a problem hiding this comment.
还有主从复制为什么要适配codis，主从复制我理解不需要codis
是做“分布式”，并非做主从复制
There was a problem hiding this comment.
还有主从复制为什么要适配codis，主从复制我理解不需要codis
是做“分布式”，并非做主从复制
我看了一下这个命令的复用性不是很大，大概率要重新设计适配codis
AlexStocks
approved these changes
May 12, 2023
luky116
approved these changes
May 12, 2023
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.