Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unit Test]fix: maxmemory.tcl & printver.tcl #1624 #1625

Merged
merged 8 commits into from
Jun 19, 2023

Conversation

chenbt-hz
Copy link
Collaborator

fix: #1624

./pikatests.sh maxmemory
rm: src/redis-server: No such file or directory
BUILD_DIR: output
run pika tests maxmemory
Cleanup: may take some time... OK
Starting test server at port 11111
[ready]: 96342
Testing unit/maxmemory
Starting ---- 
Before Wait
After Wait
[ok]: Without maxmemory small integers are shared
[ok]: Check for memory leaks (pid 96344)
Waiting for process 96344 to exit...
Waiting for process 96344 to exit...
Waiting for process 96344 to exit...
Waiting for process 96344 to exit...
Forcing process 96344 to exit...
[1/1 done]: unit/maxmemory (15 seconds)

                   The End

Execution time of different units:
  15 seconds - unit/maxmemory

\o/ All tests passed without errors!

Cleanup: may take some time... OK

fix: printver.tcl

./pikatests.sh printver          
rm: src/redis-server: No such file or directory
BUILD_DIR: output
run pika tests printver
Cleanup: may take some time... OK
Starting test server at port 11111
[ready]: 95762
Testing unit/printver
Starting ---- 
Before Wait
After Wait
Testing Pika version 3.4.2 (7d4f628492c68581fd67d76b75fc0f1b2b88a817)
Waiting for process 95764 to exit...
Waiting for process 95764 to exit...
Waiting for process 95764 to exit...
Waiting for process 95764 to exit...
[1/1 done]: unit/printver (13 seconds)

                   The End

Execution time of different units:
  13 seconds - unit/printver

\o/ All tests passed without errors!

Cleanup: may take some time... OK

Copy link
Collaborator

@machinly machinly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最好是注视掉,然后写明为什么注释。
以及在wiki里把不支持的命令加上,以便后续与redis对齐。

tests/unit/printver.tcl Show resolved Hide resolved
@chenbt-hz chenbt-hz requested a review from luky116 June 17, 2023 08:35
@chenbt-hz
Copy link
Collaborator Author

最好是注视掉,然后写明为什么注释。 以及在wiki里把不支持的命令加上,以便后续与redis对齐。

已处理

machinly
machinly previously approved these changes Jun 17, 2023
Copy link
Collaborator

@machinly machinly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以顺便把 tests/test_helper.tcl 里相关的文件取消注释,这样ci就能能串上了。

@machinly machinly self-requested a review June 19, 2023 05:44
@AlexStocks AlexStocks merged commit 0dc9344 into OpenAtomFoundation:unstable Jun 19, 2023
8 checks passed
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
…penAtomFoundation#1625)

* fix unit test:type/set

* 修复printver.tcl

* 修复maxmemory.tcl不支持的命令,新增一个config get的单测

* 添加注释信息与原redis相关测试用例

* tests/test_helper.tcl 取消注释
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Unit Test] maxmemory相关,建议删除
3 participants